feat: Mock chain ID and network version calls in simulation #3017
+129
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/mock-chain-id-in-simulation
branch
from
b11c90b to
5528ba9
Compare
Mrtenz
approved these changes
Jan 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3017 +/- ##
=======================================
Coverage 94.75% 94.76%
=======================================
Files 497 499 +2
Lines 10896 10906 +10
Branches 1674 1674
=======================================
+ Hits 10325 10335 +10
Misses 571 571 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mock calls to
eth_chainIdandnet_versionin the simulation framework, so users don't have to mock them manually.This should also prevent some flakiness in our tests.